Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

align :float and :double generators #1143

Merged
merged 3 commits into from
Dec 8, 2024

Conversation

frenchy64
Copy link
Collaborator

@frenchy64 frenchy64 commented Dec 4, 2024

Close #1132

My thinking is we should follow clojure.spec.gen.alpha where float? and double? generate the same (and thus the corresponding schemas).

@frenchy64 frenchy64 force-pushed the float-generator branch 2 times, most recently from 157c824 to 34f1e3d Compare December 4, 2024 05:06
@frenchy64 frenchy64 marked this pull request as ready for review December 4, 2024 05:12
@ikitommi ikitommi merged commit 1e489c8 into metosin:master Dec 8, 2024
13 checks passed
@ikitommi
Copy link
Member

ikitommi commented Dec 8, 2024

thx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

:float accepts doubles but never generates them
2 participants