Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#55: replace unicode plus or minus sign with ascii-compatible form #56

Conversation

benfitzpatrick
Copy link
Contributor

This closes #55.

@matthewrmshin, please review.

@benfitzpatrick benfitzpatrick added this to the next-release milestone Jul 21, 2014
@matthewrmshin
Copy link
Member

I am thinking, why not just use a single + sign to force a sign, like in C's sprintf or Python's string formatting operations?

@benfitzpatrick
Copy link
Contributor Author

That precedent is interesting - I'm still leaning towards a +- because it is
immediately human readable, and won't confuse people who want to work
with negative years.

@benfitzpatrick
Copy link
Contributor Author

I'm not convinced that this (in itself) is better for users, but I suppose at least
it's a standard.

matthewrmshin added a commit that referenced this pull request Jul 21, 2014
…-minus-sign

#55: replace unicode plus or minus sign with ascii-compatible form
@matthewrmshin matthewrmshin merged commit cf91121 into metomi:master Jul 21, 2014
@matthewrmshin matthewrmshin modified the milestones: next-release, 2014.06 Jul 21, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get rid of plus-or-minus unicode parser token
2 participants