parsers: raise ValueError for invalid TimePoints #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests unhappy. 😭 |
|
I tried changing the logic in the tick methods some time ago (#101) and found that for each scenario I added a fix, it actually broke the logic in some other scenarios 😞 |
|
Some tests broken due to timezone change. It looks like this configuration does nothing: [pytest]
-env =
- TZ=UTC |
oliver-sanders
force-pushed
the
parser-validate-input-time-point
branch
from
ae77c5d
to
3cbd764
Compare
|
We should probably add a configuration for Bandit to ignore the |
kinow
approved these changes
Apr 10, 2019
matthewrmshin
approved these changes
Apr 10, 2019
oliver-sanders
added a commit
to oliver-sanders/cylc-flow
that referenced
this pull request
Apr 11, 2019
kinow
added a commit
to cylc/cylc-flow
that referenced
this pull request
Apr 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.