Fix for bug in ordinal date and week additon in timepoint #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhuggett
force-pushed
the
ordinal_date_fix
branch
from
fd79490
to
48a9f4e
Compare
Codecov Report
@@ Coverage Diff @@
## master #106 +/- ##
==========================================
- Coverage 90.22% 90.17% -0.06%
==========================================
Files 7 7
Lines 1924 1924
Branches 540 540
==========================================
- Hits 1736 1735 -1
- Misses 188 189 +1
Continue to review full report at Codecov.
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #105. ">" swapped for "<" in relevant cases to prevent day-of-year always being set to the maximum number of days in the year, and week-of-year always being set to the maximum number of weeks in that year.