This repository has been archived by the owner on Feb 26, 2021. It is now read-only.
Fix tests #210
Merged
Fix tests #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sts and todos, but no one remembered to update the tests . . .
This was referenced Jan 24, 2017
|
Awesome, thanks @GeoffreyBooth! Yes, issue #198 is a real pain :-( ... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So at some point, the collections were renamed from
ListsandTodostolistsandtodos, but no one updated the tests to reflect this. With this update the tests (as run viarm -Rf .meteor/local/plugin-cache; meteor npm test) pass.About that command: I seem to be hit hard by #198 / DispatchMe/meteor-mocha-phantomjs#33, and the solution in this comment was the only way I could get the tests to run. This should really be fixed. The CI server isn’t even running the real tests, it’s running a single test that looks like a stub.