feat!(config): remove default value on window

metcoder95 · Jan 10, 2023 · 5e302bd · 5e302bd
1 parent a498529
commit 5e302bd
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 12 deletions.
diff --git a/README.md b/README.md
@@ -145,9 +145,7 @@ Standard Options:
 
     Stability window, the time in ms defining the window of time that
     resource needs to have not changed (file size or availability) before
-    signalling success, default 750ms. If less than interval, it will be
-    reset to the value of interval. This is only used for files, other
-    resources are considered available on first detection.
+    signalling success.
 
   -h, --help
 

diff --git a/help.txt b/help.txt
@@ -90,9 +90,7 @@ Standard Options:
 
     Stability window, the time in ms defining the window of time that
     resource needs to have not changed (file size or availability) before
-    signalling success, default 750ms. If less than interval, it will be
-    reset to the value of interval. This is only used for files, other
-    resources are considered available on first detection.
+    signalling success.
 
   -h, --help
 

diff --git a/index.js b/index.js
@@ -48,7 +48,7 @@ async function waitOnImpl (opts) {
   }
 
   // window needs to be at least interval
-  if (waitOnOptions.window < waitOnOptions.interval) {
+  if (waitOnOptions.window != null && waitOnOptions.window < waitOnOptions.interval) {
     waitOnOptions.window = waitOnOptions.interval
   }
 

diff --git a/lib/validate.js b/lib/validate.js
@@ -159,8 +159,7 @@ module.exports = {
       },
       window: {
         type: 'integer',
-        minimum: 0,
-        default: 250
+        minimum: 0
       },
       proxy: {
         type: 'object',

diff --git a/test/http.test.js b/test/http.test.js
@@ -6,7 +6,7 @@ const { test } = require('tap')
 
 const waitOn = require('..')
 
-test('Wait-On#HTTP', { only: true }, context => {
+test('Wait-On#HTTP', context => {
   context.plan(7)
 
   context.test('Basic HTTP', async t => {
@@ -89,7 +89,7 @@ test('Wait-On#HTTP', { only: true }, context => {
         }
       })
 
-      t.plan(4)
+      t.plan(3)
       t.teardown(server.close.bind(server))
 
       const waiting = waitOn({
@@ -114,7 +114,7 @@ test('Wait-On#HTTP', { only: true }, context => {
       const result = await waiting
 
       t.equal(result, true)
-      t.equal(callbackCalled, 3)
+      t.equal(callbackCalled, 2)
     }
   )