fix: fix for automatic HEAD routes #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HEAD routes now get automatically added in Fastify causing and issue when the path exists (via GET) but the HEAD method does not. This fix covers that case.
metcoder95
reviewed
Sep 27, 2022
|
Skipping tests for now, as needed for release of v2 with support for |
metcoder95
changed the title
metcoder95
pushed a commit
that referenced
this pull request
Oct 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fastify 4 creates sibling HEAD routes for GET routes by default.
https://www.fastify.io/docs/latest/Guides/Migration-Guide-V4/#exposeheadroutes-true-by-default
This causes an error in the split validator when the path exists (via GET) but the HEAD method does not.
This fix covers that case.