Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to use short version @v4 #263

Closed
powerman opened this issue Oct 25, 2024 · 4 comments · May be fixed by #266
Closed

Unable to use short version @v4 #263

powerman opened this issue Oct 25, 2024 · 4 comments · May be fixed by #266
Assignees
@metcalfc
Labels
bug Something isn't working

Comments

@powerman
Copy link

Describe the bug
Error: Unable to resolve action metcalfc/changelog-generator@v4, unable to find version v4

To Reproduce

      - name: Generate changelog
        id: changelog
        uses: metcalfc/changelog-generator@v4
        with:
          myToken: ${{ secrets.GITHUB_TOKEN }}

Expected behavior
It should work using latest v4 version.

URL to Public action log
https://github.com/powerman/dockerize/actions/runs/11516609425/job/32059618802

Additional context
Similar issue: ast-grep/action#38
@powerman powerman added the bug Something isn't working label Oct 25, 2024
@metcalfc
Copy link
Owner

metcalfc commented Nov 6, 2024

@powerman That sucks. I'll figure this out. Thanks for the additional context that's useful.

metcalfc added a commit that referenced this issue Nov 6, 2024
@metcalfc
Fix version tag issue and update workflows
628a055 
Fixes #263

Add a step to update the git tag with the major version in the `release.yml` workflow.

* Add a new step "Update Major Version Tag" after the "Create Release" step
* Extract the major version from the full semver string and create a new git tag with just the major version
* Push the new tag to the repository using the `GITHUB_TOKEN` for authentication

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/metcalfc/changelog-generator/issues/263?shareId=XXXX-XXXX-XXXX-XXXX).
@metcalfc metcalfc mentioned this issue Nov 6, 2024
Open
@metcalfc
Copy link
Owner

metcalfc commented Nov 6, 2024

@powerman Can you check if this works now?

@powerman
Copy link
Author

powerman commented Nov 7, 2024 •
edited
Loading

Yeah, it works now.

So, it looks like GitHub somehow broke this version-prefix feature and now it require manually creating and moving tags (tags! which are supposed to never change in git best practice!), right? Is there any official GitHub docs related to this? Are these docs actually recommends moving major version tags on each release?

@powerman
Copy link
Author

powerman commented Nov 7, 2024

Yeah, that's in official docs. 😞 https://docs.github.com/en/actions/sharing-automations/creating-actions/releasing-and-maintaining-actions#setting-up-github-actions-workflows

@powerman powerman closed this as completed Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@metcalfc metcalfc

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix version tag issue and update workflows metcalfc/changelog-generator
2 participants
@metcalfc @powerman