-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore proper choice behavior in schema generation #263
Restore proper choice behavior in schema generation #263
Conversation
…sure schemas are generated directly from the loaded module and not the compiled version. Fixes metaschema-framework#259
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good! quick fix!
7c6b05c
into
metaschema-framework:develop
Committer Notes
Delayed registering module to just before constraint validation to ensure schemas are generated directly from the loaded module and not the compiled version.
This issue was caused by the lack for proper choice support in generated bindings. Previous versions of this library used the loaded Metaschema module information directly, without first generating classes for the module. This was changed in the 2.0.0 and 2.0.1 versions. This PR restores the original behavior.
See #262 for follow-on work to fully implement the choice construct in generated bindings.
Resolves #259
All Submissions:
By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.
Changes to Core Features: