Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
デプロイ時に更新したはずのブランチが適用されず、genova再起動で解消するケースがありました。
特定の環境で短期間に2度発生していることから、5.0.1で更新したgitのGem更新が関連している可能性があります。
また、
Dir.chdir
におけるスレッドセーフ問題が修正が取り込まれた1.19
ではなく1.18
をインストールしていたので、合わせて修正となります。以下はデプロイ時のログです。
https://github.com/metaps/genova/blob/develop/lib/autoloads/genova/code_manager/git.rb#L28-L42