Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix builders order on append #118

Merged
merged 2 commits into from
Jan 25, 2024
Merged

Fix builders order on append #118

merged 2 commits into from
Jan 25, 2024

Conversation

febo
Copy link
Contributor

@febo febo commented Jan 21, 2024

This PR fixes the order of builders on the append method of a TransactionBuilderGroup – currently it has the same behaviour as prepend.

Copy link

changeset-bot bot commented Jan 21, 2024

🦋 Changeset detected

Latest commit: 2b0ded4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 20 packages
Name Type
@metaplex-foundation/umi Patch
@metaplex-foundation/umi-bundle-defaults Patch
@metaplex-foundation/umi-bundle-tests Patch
@metaplex-foundation/umi-downloader-http Patch
@metaplex-foundation/umi-eddsa-web3js Patch
@metaplex-foundation/umi-http-fetch Patch
@metaplex-foundation/umi-program-repository Patch
@metaplex-foundation/umi-rpc-chunk-get-accounts Patch
@metaplex-foundation/umi-rpc-web3js Patch
@metaplex-foundation/umi-serializer-beet Patch
@metaplex-foundation/umi-serializer-data-view Patch
@metaplex-foundation/umi-signer-derived Patch
@metaplex-foundation/umi-signer-wallet-adapters Patch
@metaplex-foundation/umi-storage-mock Patch
@metaplex-foundation/umi-transaction-factory-web3js Patch
@metaplex-foundation/umi-uploader-aws Patch
@metaplex-foundation/umi-uploader-bundlr Patch
@metaplex-foundation/umi-uploader-irys Patch
@metaplex-foundation/umi-uploader-nft-storage Patch
@metaplex-foundation/umi-web3js-adapters Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@febo febo requested a review from lorisleiva January 21, 2024 23:19
Copy link
Collaborator

@lorisleiva lorisleiva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦‍♂️ Thank you!

@lorisleiva lorisleiva merged commit c450559 into main Jan 25, 2024
6 checks passed
@lorisleiva lorisleiva deleted the febo/fix-append branch January 25, 2024 16:23
@github-actions github-actions bot mentioned this pull request Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants