feat: support account collections for instructions #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* master: 0.16.0 feat: support sets (#86)
- adding collection name as prefix makes it easier to discover collection items via intellisense, i.e. `sourceMarketItemCoinVault` as well as making clear where each account item originated from
|
Hi @ricardocr987 . Just making sure this didn't go unnoticed by accident. Please LMK if the changes I made are acceptable. |
|
yep, the code is much cleaner and the solution also suits to me, thank you very much |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Superseedes #81 (which includes further description)
FIXES: #78
This builds on top of the related PR by @ricardocr987 and adapts mainly how items of account
collections are named.
Instead of just upper-casing them to avoid name clashes the name now is prefixed with the
collection name and suffixed with the account item. This makes them easy to discover on top of
avoiding name clashes.
Sample Completion
The below shows clearly that the account item names help discover accounts by collection easily.