fix: handling empty accounts for anchor remaining accounts #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The intent of this PR was to just handle the case of empty accounts when we try to add
anchorRemainingAccounts. In this case we just assume that there are none and thus don'trender any of the code allowing users to add them.
If this assumption was wrong we need to iterate on this solution.
As a side effect I ran into issues with web3.js (missing cross-fetch) which originated from it
being a dep of beet-solita.
Thus after upgrading numerous deps in the beet
repo we updated the beet deps here to
pull in those patches.