Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for isOptional instruction account attribute #106

Merged
merged 2 commits into from
Feb 17, 2023
Merged

Add support for isOptional instruction account attribute #106

merged 2 commits into from
Feb 17, 2023

Conversation

lorisleiva
Copy link
Contributor

Problem

Anchor labels optional instruction accounts using the isOptional attribute whereas Solita expects the optional attribute as Shank uses the latter.

Solution

Support both optional and isOptional attributes to label optional instruction accounts.

@lorisleiva lorisleiva self-assigned this Feb 17, 2023
febo
febo approved these changes Feb 17, 2023
View reviewed changes
Copy link
Contributor

@febo febo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR adds compatibility with Anchor optional accounts IDL notation.

@lorisleiva lorisleiva merged commit 202d823 into master Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@febo febo febo approved these changes

Assignees

@lorisleiva lorisleiva

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lorisleiva @febo