This repository has been archived by the owner on Oct 2, 2024. It is now read-only.
added update metadata with parametrized seller fee #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parametrized sellers fee added update added update added update reordered arguments
jarry-xiao
approved these changes
Oct 14, 2021
|
Thanks looks good |
|
Is it possible to update the metadata before minting? |
which metadata? this pr does exactly update even after minting. |
| def update_metadata_instruction_data(name, symbol, uri, creators, verified, share): | ||
| _data = bytes([1]) + _get_data_buffer(name, symbol, uri, creators, verified, share) + bytes([0, 0]) | ||
| def update_metadata_instruction_data(name, symbol, uri, fee, creators, verified, share): | ||
| _data = bytes([1]) + _get_data_buffer(name, symbol, uri, fee, creators, verified, share) + bytes([0, 0]) |
There was a problem hiding this comment.
Mr. Jarry, is the byte at the "+ bytes([0, 0])" for primary_sale_happened and is_mutable?
I think they are the ones we would change if we would like to change the primary_sale_happened and is_mutable right?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the ability to update metadata and set the seller fee (was set to 0 by default)