Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rust client sdk #41

Merged
merged 32 commits into from
Aug 25, 2023
Merged

Add rust client sdk #41

merged 32 commits into from
Aug 25, 2023

Conversation

febo
Copy link
Contributor

@febo febo commented Aug 18, 2023

This PR adds a Rust client SDK with minimal dependency requirements. More details of how to use the SDK are presented on the README.md file.

@febo febo marked this pull request as ready for review August 22, 2023 22:15
@febo febo requested review from blockiosaurus, danenbm and lorisleiva and removed request for blockiosaurus and danenbm August 22, 2023 22:16
@febo febo requested review from blockiosaurus and danenbm August 22, 2023 22:16
lorisleiva
lorisleiva suggested changes Aug 23, 2023
View reviewed changes
Copy link
Contributor

@lorisleiva lorisleiva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work Febo! It's so nice to see it all come together after all your work on the Rust rendered.

I've left a few comments but nothing major. Let me know what you think.

.github/file-filters.yml Outdated Show resolved Hide resolved
.github/workflows/main.yml Show resolved Hide resolved
.github/workflows/build-rust-client.yml Outdated Show resolved Hide resolved
clients/rust/tests/create.rs Show resolved Hide resolved
configs/program-scripts/sdk.sh Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
clients/js/src/generated/instructions/approveCollectionAuthority.ts Outdated Show resolved Hide resolved
clients/rust/README.md Show resolved Hide resolved
clients/rust/src/generated/accounts/master_edition.rs Outdated Show resolved Hide resolved
clients/rust/src/generated/errors/mpl_token_metadata.rs Show resolved Hide resolved
blockiosaurus
blockiosaurus previously approved these changes Aug 23, 2023
View reviewed changes
lorisleiva
lorisleiva suggested changes Aug 24, 2023
View reviewed changes
Copy link
Contributor

@lorisleiva lorisleiva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just one more tweak on that test JS client script.

configs/client-scripts/test-js-client.sh Outdated Show resolved Hide resolved
danenbm
danenbm reviewed Aug 24, 2023
View reviewed changes
clients/rust/src/generated/accounts/master_edition.rs Outdated Show resolved Hide resolved
clients/js/test/printV1.test.ts Show resolved Hide resolved
clients/rust/Cargo.toml Show resolved Hide resolved
clients/rust/README.md Outdated Show resolved Hide resolved
clients/rust/README.md Outdated Show resolved Hide resolved
clients/rust/tests/create.rs Show resolved Hide resolved
clients/rust/src/hooked/metadata_delegate_role_seed.rs Outdated Show resolved Hide resolved
@febo febo requested review from lorisleiva and danenbm August 24, 2023 17:40
danenbm
danenbm previously approved these changes Aug 24, 2023
View reviewed changes
@febo febo requested a review from danenbm August 24, 2023 21:32
danenbm
danenbm approved these changes Aug 24, 2023
View reviewed changes
Copy link
Contributor

@danenbm danenbm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

lorisleiva
lorisleiva approved these changes Aug 25, 2023
View reviewed changes
Copy link
Contributor

@lorisleiva lorisleiva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@febo febo merged commit d1a1327 into main Aug 25, 2023
@febo febo deleted the febo/rust-sdk branch August 25, 2023 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danenbm danenbm danenbm approved these changes

@lorisleiva lorisleiva lorisleiva approved these changes

@blockiosaurus blockiosaurus Awaiting requested review from blockiosaurus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@febo @lorisleiva @danenbm @blockiosaurus