Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update mpl token auth rules to the recent 1.18 solana #154

Merged
merged 2 commits into from
Jul 22, 2024

Conversation

rwwwx
Copy link
Contributor

@rwwwx rwwwx commented Jul 19, 2024

No description provided.

Copy link

vercel bot commented Jul 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mpl-token-auth-rules-js-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 19, 2024 10:42am

@rwwwx
Copy link
Contributor Author

rwwwx commented Jul 19, 2024

As far as I understand JS client check was skipped because ci didn't detect any changes related to JS in this PR, so I think it's fine 🤔

@rwwwx rwwwx requested review from StanChe, n00m4d, mack-hom and danenbm July 19, 2024 11:23
@rwwwx rwwwx marked this pull request as ready for review July 19, 2024 11:24
@rwwwx rwwwx removed the request for review from mack-hom July 19, 2024 11:25
Copy link

@StanChe StanChe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, thanks! Let's wait for an approval from @blockiosaurus and merge it

@StanChe StanChe requested review from blockiosaurus and removed request for danenbm July 19, 2024 14:41
@rwwwx rwwwx merged commit fd9026d into main Jul 22, 2024
7 checks passed
@rwwwx rwwwx deleted the 419-Update-mpl-token-auth-rules-to-the-recent-1.18-solana branch July 22, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants