burn-transfer-for-compressed-nfts #4
Conversation
|
@danenbm I tried to reduce cognitive complexity (though without making methods more modular) and it seems like I made it more complex. wdyt? |
| if ctx.accounts.authority.key != &asset.owner { | ||
| return Err(MplCoreError::InvalidAuthority.into()); | ||
| } |
There was a problem hiding this comment.
What I'm thinking is that we want to have it be consistent across all instructions so like we do asset.check_burn(), then asset.validate_burn().... later plugin.check_burn(), then plugin.validate_burn(). And in any other ix call the same kind of check/validate methods.
But let me have a quick chat with @blockiosaurus tomorrow about the permissions model, since I have heard some talk about changes so we might have a different way to go about it.
There was a problem hiding this comment.
Ok unfortunately there's been more significant changes in main due to collection permissions, and I have some other suggestions for the team for the new way it works. I think maybe we need to pair program this tomorrow. We can discuss in standup.
|
This has been covered by: #12 |
add delegates checking for compressed nfts within both burn and transfer functions