UpdateDelegate Change UA/Collection #204
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e update delegate.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Benchmark
| Benchmark suite | Current: ea8324b | Previous: 729fde8 | Ratio |
|---|---|---|---|
CU: create a new, empty asset |
11082 Compute Units |
11082 Compute Units |
1 |
Space: create a new, empty asset |
91 Bytes |
91 Bytes |
1 |
CU: create a new, empty asset with empty collection |
22555 Compute Units |
22555 Compute Units |
1 |
Space: create a new, empty asset with empty collection |
91 Bytes |
91 Bytes |
1 |
CU: create a new asset with plugins |
40123 Compute Units |
40123 Compute Units |
1 |
Space: create a new asset with plugins |
194 Bytes |
194 Bytes |
1 |
CU: create a new asset with plugins and empty collection |
46145 Compute Units |
46145 Compute Units |
1 |
Space: create a new asset with plugins and empty collection |
194 Bytes |
194 Bytes |
1 |
CU: list an asset |
30237 Compute Units |
30237 Compute Units |
1 |
CU: sell an asset |
38824 Compute Units |
38824 Compute Units |
1 |
CU: list an asset with empty collection |
37795 Compute Units |
37795 Compute Units |
1 |
CU: sell an asset with empty collection |
51152 Compute Units |
51152 Compute Units |
1 |
CU: list an asset with collection royalties |
38499 Compute Units |
38499 Compute Units |
1 |
CU: sell an asset with collection royalties |
56077 Compute Units |
56077 Compute Units |
1 |
CU: transfer an empty asset |
6320 Compute Units |
6320 Compute Units |
1 |
CU: transfer an empty asset with empty collection |
8918 Compute Units |
8918 Compute Units |
1 |
CU: transfer an asset with plugins |
14604 Compute Units |
14604 Compute Units |
1 |
CU: transfer an asset with plugins and empty collection |
17202 Compute Units |
17202 Compute Units |
1 |
This comment was automatically generated by workflow using github-action-benchmark.
danenbm
requested changes
Dec 18, 2024
Comment on lines
-167
to
+172
| if ((ctx.resolved_authorities.is_some() | ||
| && ctx | ||
| .resolved_authorities | ||
| .unwrap() | ||
| .contains(ctx.self_authority)) | ||
| || self.additional_delegates.contains(ctx.authority_info.key)) | ||
| // We do not allow the root authority (either Collection or Address) to be changed by this delegate. | ||
| && ctx.new_collection_authority.is_none() && ctx.new_asset_authority.is_none() | ||
| if (ctx.resolved_authorities.is_some() | ||
| && ctx | ||
| .resolved_authorities | ||
| .unwrap() | ||
| .contains(ctx.self_authority)) | ||
| || self.additional_delegates.contains(ctx.authority_info.key) |
There was a problem hiding this comment.
I think validate_update is used for both asset plugins and collection plugins. So wouldn't this allow an update delegate on an asset to remove itself from a collection, which I think we don't want per the offline discussion?
| test('it cannot remove an asset from collection using update delegate', async (t) => { | ||
| test('it can remove an asset from collection using update delegate', async (t) => { |
There was a problem hiding this comment.
If my other comment is true then I think we should keep tests for not allowing asset update delegates and asset additional update delegates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the ability to change the update authority or collection as the update delegate.