Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use external plugin adapter authority to validate #170

Merged
merged 5 commits into from
Jul 22, 2024
Merged

Use external plugin adapter authority to validate #170

merged 5 commits into from
Jul 22, 2024

Conversation

danenbm
Copy link
Contributor

@danenbm danenbm commented Jul 15, 2024 •
edited
Loading

Notes

  • Use external plugin adapter authority to validate updating it.
  • Also fix bug where modifying lifecycle events for external plugin adapters was not getting updated in the registry record.
  • Per offline discussion, remove the full-on lifecycle checks process when updating external plugin adapters.
  • Remove now-unused function.

@vercel Vercel
Copy link

vercel bot commented Jul 15, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mpl-core-js-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 16, 2024 8:09am

@danenbm danenbm force-pushed the danenbm/ext-plugin-adapter-auth branch from 9af10f1 to 43e5f4c Compare July 15, 2024 06:10
@danenbm danenbm force-pushed the danenbm/ext-plugin-adapter-auth branch from 43e5f4c to b87161c Compare July 15, 2024 06:37
@danenbm danenbm force-pushed the danenbm/ext-plugin-adapter-auth branch from b87161c to 6690004 Compare July 15, 2024 06:59
@danenbm danenbm marked this pull request as ready for review July 16, 2024 08:06
@danenbm danenbm merged commit 24a98e0 into main Jul 22, 2024
12 checks passed
@danenbm danenbm deleted the danenbm/ext-plugin-adapter-auth branch July 22, 2024 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blockiosaurus blockiosaurus blockiosaurus approved these changes

@nhanphan nhanphan Awaiting requested review from nhanphan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danenbm @blockiosaurus