Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tests): add unimplemented create tests #17

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

shotgunofdeath
Copy link
Contributor

Description

Unimplemented tests in create.test.ts are added

@shotgunofdeath
Copy link
Contributor Author

@blockiosaurus @nhanphan

I have some doubts regarding the "it cannot create a new asset if the address is not owned by the system program" test
https://github.com/metaplex-foundation/mpl-core/pull/17/files#diff-66262f5244b2e1e6afaae1aeb007c0dc8b94b092b8281d5c60d27787ad4a61a5R229

The thing is that I get the same error even if I use the the system program (splSystem) instead of the mpl-core one while creating an account. AFAIU from the test description, the asset should be created successfully when using an account with the system program as an owner.

@shotgunofdeath
Copy link
Contributor Author

@blockiosaurus removed the "sign" tests as discussed. 43067f0

@shotgunofdeath shotgunofdeath merged commit f4cf837 into main Mar 14, 2024
6 of 7 checks passed
@shotgunofdeath shotgunofdeath deleted the feat/create-tests branch March 14, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants