Updating revoke to include default behavior for Address #168
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| let base_result = if ctx.self_authority | ||
| == &(Authority::Address { | ||
| address: *ctx.authority_info.key, | ||
| }) |
There was a problem hiding this comment.
I think there may be an issue with this, which isn't related to your PR but a problem with this logic in general.
If you set the authority to the Update Authority on an owner-managed plugin, and then you sign revokePluginAuthority as the Update Authority, it won't be approved by the asset, and since it is not a plain address, it will not be approved here by the plugin, so the Update Authority would never be able to self-revoke.
I think its a similar problem for an authority-managed plugin with authority set to Owner. In that case, Owner would never be able to self-revoke.
I had a backlog item to fix this on my list, but it becomes easier with your PR I think because you moved the default behavior to one spot. Maybe all we need to do is add a check here for the other Authority types?
I approved the PR without this change if you don't want to increase scope of it at the moment.
No description provided.