Require passing in oracle lifecycle checks Vec

clients/js/src/generated/errors/mplCore.ts

@@ -492,22 +492,42 @@ export class MissingExternalAccountError extends ProgramError {
 codeToErrorMap.set(0x22, MissingExternalAccountError);
 nameToErrorMap.set('MissingExternalAccount', MissingExternalAccountError);
 
-/** OracleCanDenyOnly: Oracle external plugin can only be configured to deny */
-export class OracleCanDenyOnlyError extends ProgramError {
-  override readonly name: string = 'OracleCanDenyOnly';
+/** OracleCanRejectOnly: Oracle external plugin can only be configured to reject */
+export class OracleCanRejectOnlyError extends ProgramError {
+  override readonly name: string = 'OracleCanRejectOnly';
 
   readonly code: number = 0x23; // 35
 
   constructor(program: Program, cause?: Error) {
     super(
-      'Oracle external plugin can only be configured to deny',
+      'Oracle external plugin can only be configured to reject',
       program,
       cause
     );
   }
 }
-codeToErrorMap.set(0x23, OracleCanDenyOnlyError);
-nameToErrorMap.set('OracleCanDenyOnly', OracleCanDenyOnlyError);
+codeToErrorMap.set(0x23, OracleCanRejectOnlyError);
+nameToErrorMap.set('OracleCanRejectOnly', OracleCanRejectOnlyError);
+
+/** OracleRequiresLifecycleCheck: Oracle external plugin must have at least one lifecycle check */
+export class OracleRequiresLifecycleCheckError extends ProgramError {
+  override readonly name: string = 'OracleRequiresLifecycleCheck';
+
+  readonly code: number = 0x24; // 36
+
+  constructor(program: Program, cause?: Error) {
+    super(
+      'Oracle external plugin must have at least one lifecycle check',
+      program,
+      cause
+    );
+  }
+}
+codeToErrorMap.set(0x24, OracleRequiresLifecycleCheckError);
+nameToErrorMap.set(
+  'OracleRequiresLifecycleCheck',
+  OracleRequiresLifecycleCheckError
+);
 
 /**
  * Attempts to resolve a custom program error from the provided error code.

clients/js/src/generated/types/baseOracleInitInfo.ts

@@ -36,17 +36,15 @@ import {
 export type BaseOracleInitInfo = {
   baseAddress: PublicKey;
   initPluginAuthority: Option<BasePluginAuthority>;
-  lifecycleChecks: Option<Array<[HookableLifecycleEvent, ExternalCheckResult]>>;
+  lifecycleChecks: Array<[HookableLifecycleEvent, ExternalCheckResult]>;
   pda: Option<BaseExtraAccount>;
   resultsOffset: Option<BaseValidationResultsOffset>;
 };
 
 export type BaseOracleInitInfoArgs = {
   baseAddress: PublicKey;
   initPluginAuthority: OptionOrNullable<BasePluginAuthorityArgs>;
-  lifecycleChecks: OptionOrNullable<
-    Array<[HookableLifecycleEventArgs, ExternalCheckResultArgs]>
-  >;
+  lifecycleChecks: Array<[HookableLifecycleEventArgs, ExternalCheckResultArgs]>;
   pda: OptionOrNullable<BaseExtraAccountArgs>;
   resultsOffset: OptionOrNullable<BaseValidationResultsOffsetArgs>;
 };
@@ -61,13 +59,11 @@ export function getBaseOracleInitInfoSerializer(): Serializer<
       ['initPluginAuthority', option(getBasePluginAuthoritySerializer())],
       [
         'lifecycleChecks',
-        option(
-          array(
-            tuple([
-              getHookableLifecycleEventSerializer(),
-              getExternalCheckResultSerializer(),
-            ])
-          )
+        array(
+          tuple([
+            getHookableLifecycleEventSerializer(),
+            getExternalCheckResultSerializer(),
+          ])
         ),
       ],
       ['pda', option(getBaseExtraAccountSerializer())],

clients/js/src/helpers/lifecycle.ts

@@ -96,7 +96,7 @@ export async function validateTransfer(
   }
 
   if (isFrozen(asset, collection)) {
-    return LifecycleValidationError.AssetFrozen
+    return LifecycleValidationError.AssetFrozen;
   }
 
   if (dAsset.oracles?.length) {

clients/js/src/plugins/lifecycleChecks.ts

@@ -85,7 +85,7 @@ export function lifecycleChecksToBase(
     })
     .filter((x) => x !== null) as [
     HookableLifecycleEvent,
-    ExternalCheckResult
+    ExternalCheckResult,
   ][];
 }
 

clients/js/src/plugins/oracle.ts

@@ -40,7 +40,7 @@ export type OracleInitInfoArgs = Omit<
 > & {
   type: 'Oracle';
   initPluginAuthority?: PluginAuthority;
-  lifecycleChecks?: LifecycleChecks;
+  lifecycleChecks: LifecycleChecks;
   pda?: ExtraAccount;
   resultsOffset?: ValidationResultsOffset;
 };
@@ -61,9 +61,7 @@ export function oracleInitInfoArgsToBase(
   return {
     baseAddress: o.baseAddress,
     pda: o.pda ? extraAccountToBase(o.pda) : null,
-    lifecycleChecks: o.lifecycleChecks
-      ? lifecycleChecksToBase(o.lifecycleChecks)
-      : null,
+    lifecycleChecks: lifecycleChecksToBase(o.lifecycleChecks),
     initPluginAuthority: o.initPluginAuthority
       ? pluginAuthorityToBase(o.initPluginAuthority)
       : null,