Fix offset calculation for external plugins

metaplex-foundation · May 8, 2024 · ba777c9 · ba777c9
1 parent 65c5d8a
commit ba777c9
Showing 1 changed file with 8 additions and 6 deletions.
diff --git a/programs/mpl-core/src/processor/update_external_plugin.rs b/programs/mpl-core/src/processor/update_external_plugin.rs
@@ -222,19 +222,21 @@ fn process_update_external_plugin<'a, T: DataBlob + SolanaAccount>(
     // Move offsets for existing registry records.
     for record in &mut plugin_registry.external_registry {
         if registry_record.offset < record.offset {
-            record
-                .offset
-                .checked_add(size_diff as usize)
+            let new_offset = (record.offset as isize)
+                .checked_add(size_diff)
                 .ok_or(MplCoreError::NumericalOverflow)?;
+
+            record.offset = new_offset as usize;
         }
     }
 
     for record in &mut plugin_registry.registry {
         if registry_record.offset < record.offset {
-            record
-                .offset
-                .checked_add(size_diff as usize)
+            let new_offset = (record.offset as isize)
+                .checked_add(size_diff)
                 .ok_or(MplCoreError::NumericalOverflow)?;
+
+            record.offset = new_offset as usize;
         }
     }