Nhan/asset payment #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* asset burn guard * change payer for burn
…er-multi asset burn/payment multi
Nhan/asset mint limit
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
danenbm
reviewed
May 24, 2024
Comment on lines
+6
to
+8
| * The assetBurn guard allows minting by burning the | ||
| * minter a Core Asset from a specified collection. | ||
| * The asset will be burned. |
| @@ -21,7 +21,7 @@ anchor-lang = "0.28.0" | |||
| arrayref = "0.3.6" | |||
| mpl-token-metadata = "3.2.1" | |||
| mpl-utils = { version = "0.3", default-features = false } | |||
| mpl-core = { version = "0.4.3" } | |||
| mpl-core = { version = "0.6.1" } | |||
There was a problem hiding this comment.
FYI I release 0.7.0 yesterday. I thought you were having a CPI issue with assetBurn guard and 0.6.1 is from 16 days ago.
danenbm
approved these changes
May 24, 2024
|
|
||
| assert_keys_equal(&destination_account.key(), &self.destination)?; | ||
|
|
||
| while i < usize::from(self.num) { |
There was a problem hiding this comment.
This is fine just some rust tips.
This is slightly hardcore for a number cast, I think normally you just see self.num as usize.
Also could use a for loop for i in 0..self.num as usize
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.