-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MIP-9 #97
MIP-9 #97
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for doing this so quickly! Changes look good, but left a couple comments. Also we will need to regenerate the clients, both the Umi js client and the js-solita one.
Also set specific ahash version in Rust client: cargo update -p [email protected] --precise 0.8.6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I fixed the CI issue by deleting the Cargo.lock file for the Rust client. This is a known issue that when we do cargo release, for some reason it downgrades the borsh version, causing a mismatch between borsh and kaigan packages. Also I regenerated the solita JS SDK in case anyone is still using it. I was not able to get the Solita tests to run (they don't run in CI either). They still use yarn. I went into js-solita directory and did:
but the tests hang, maybe right at the beginning with the airdrop. Unless you can figure out how to run the solita tests manually, I think since we are just adding the one error code to Solita SDK and the Solita SDK is in process of being deprecated, its probably fine to leave them. |
What
This PR adds canopy size check to CreateTree instruction as described in MIP-9