Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MET-131: Return leaf schema from mint #88

Merged
merged 3 commits into from
Mar 22, 2024

Conversation

kstepanovdev
Copy link
Contributor

No description provided.

@kstepanovdev kstepanovdev added the enhancement New feature or request label Feb 15, 2024
@kstepanovdev kstepanovdev self-assigned this Feb 15, 2024
@kstepanovdev kstepanovdev marked this pull request as draft February 15, 2024 16:33
@kstepanovdev kstepanovdev force-pushed the return-leaf-schema-from-mint branch from d81ea07 to 9e9bcf2 Compare February 15, 2024 16:38
@kstepanovdev kstepanovdev marked this pull request as ready for review February 15, 2024 16:52
@kstepanovdev kstepanovdev force-pushed the return-leaf-schema-from-mint branch from 9e9bcf2 to eec36c8 Compare February 15, 2024 17:35
@kstepanovdev kstepanovdev force-pushed the return-leaf-schema-from-mint branch from eec36c8 to 0bf2f45 Compare February 27, 2024 17:14
danenbm
danenbm previously approved these changes Mar 22, 2024
Copy link
Contributor

@danenbm danenbm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Approved withe one trivial spelling comment

@@ -117,4 +121,59 @@ mod mint {

tree_manager.assert_root(&mut context).await;
}

#[tokio::test]
async fn recieve_leaf_schema() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thank you for testing it!

@@ -101,3 +103,39 @@ test('it cannot mint an NFT from a Bubblegum tree because token standard is wron
// Then we expect a program error because metadata's token standard is FungibleAsset which is wrong.
await t.throwsAsync(promise, { name: 'InvalidTokenStandard' });
});

test('it can get LeafScheme from mint without CPI', async (t) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: schema not scheme?

@kstepanovdev kstepanovdev merged commit 02e44d2 into main Mar 22, 2024
9 checks passed
@kstepanovdev kstepanovdev deleted the return-leaf-schema-from-mint branch March 22, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants