Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update metadata Umi tests #69

Closed

Conversation

danenbm
Copy link
Contributor

@danenbm danenbm commented Jan 12, 2024

Adding the following Umi tests, ported from existing js-solita tests:

  • can update the metadata of a minted compressed NFT
  • can update metadata using the getAssetWithProof helper
  • cannot update metadata using collection update authority when collection not verified
  • can update metadata using collection update authority when collection is verified
  • cannot update metadata using tree owner when collection is verified

I just had to add the proof alias to the kinobi config, but other things such as the UpdateArgsArgs that has defaults is already set up.

A few more test cases on the way.

@danenbm danenbm changed the base branch from main to update-metadata-staging January 12, 2024 07:37
@danenbm danenbm force-pushed the danenbm/update_metadata_umi_tests branch from a82b42d to 5faac3b Compare January 12, 2024 08:19
@danenbm danenbm changed the title Danenbm/update metadata umi tests Update metadata Umi tests Jan 12, 2024
@danenbm danenbm changed the title Update metadata Umi tests Update metadata initial Umi tests Jan 12, 2024
@danenbm danenbm marked this pull request as ready for review January 12, 2024 08:39
@danenbm danenbm requested review from febo and blockiosaurus January 12, 2024 08:39
@danenbm danenbm changed the title Update metadata initial Umi tests Update metadata Umi tests Jan 12, 2024
@danenbm danenbm force-pushed the danenbm/update_metadata_umi_tests branch from 94657a6 to 7a45a14 Compare January 12, 2024 10:24
@danenbm danenbm changed the base branch from update-metadata-staging to main January 12, 2024 17:49
@danenbm danenbm changed the base branch from main to update-metadata-staging January 12, 2024 17:52
@danenbm
Copy link
Contributor Author

danenbm commented Jan 12, 2024

Replacing this PR with #70 as this has too many merge conflicts after merging update-metadata-staging into main.

@danenbm danenbm closed this Jan 12, 2024
@danenbm danenbm deleted the danenbm/update_metadata_umi_tests branch January 12, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant