Fixes to set_and_verify_collection
#43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-col Update collection verification checks
* Fix binary name * Set decompressible on tree creation
This reverts commit c203069.
danenbm
changed the title
set_and_verify_collection
danenbm
changed the title
set_and_verify_collectionset_and_verify_collection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes
set_and_verify_collectionfixesset_and_verify_collectionto overwrite an existing verified collection. After this change, the existing verified collection will have to be unverified first by the appropriate authority. To accomplish this, switched the order of the check and the field update, so that the existing collection check happens before the new collection is put into the metadata.process_collection_verification_mpl_only, because 1) its not really a MPL collection-related check, and 2) then it can fix an existing behavior that has confused some people before. The behavior is that today, when you callmint_to_collection_v1, you must pass in metadata with collectionverifiedset tofalse, and it is changed totrueduring the instruction before it is hashed and the leaf is minted. After this change, you can send it in as eitherfalseortrueand it will be set to true duringmint_to_collection_v1.SetDecompressableState.