Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auctioneer scopes #402

Merged
merged 16 commits into from
May 17, 2022
Merged

Auctioneer scopes #402

merged 16 commits into from
May 17, 2022

Conversation

samuelvanderwaal
Copy link
Contributor

Updated the ah-scopes branch to be in line with current master.

@samuelvanderwaal samuelvanderwaal marked this pull request as ready for review April 21, 2022 22:57
blockiosaurus
blockiosaurus previously approved these changes Apr 22, 2022
View reviewed changes
Copy link
Contributor

@blockiosaurus blockiosaurus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be a correct merge and approving since I don't think any other changes were made since Austin's approval.

austbot
austbot previously requested changes Apr 27, 2022
View reviewed changes
Copy link
Contributor

@austbot austbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like some /// CHECK: TODOS are still here

auction-house/program/src/receipt/mod.rs Outdated Show resolved Hide resolved
auction-house/program/src/receipt/mod.rs Outdated Show resolved Hide resolved
blockiosaurus
blockiosaurus approved these changes May 17, 2022
View reviewed changes
Copy link
Contributor

@blockiosaurus blockiosaurus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

10/10

@samuelvanderwaal samuelvanderwaal requested a review from austbot May 17, 2022 20:48
@samuelvanderwaal samuelvanderwaal dismissed austbot’s stale review May 17, 2022 20:49

Changes addressed

@samuelvanderwaal samuelvanderwaal merged commit 1363c4a into master May 17, 2022
@samuelvanderwaal samuelvanderwaal deleted the auctioneer-scopes branch May 17, 2022 20:49
KirillLykov pushed a commit to KirillLykov/metaplex-program-library that referenced this pull request Jul 4, 2023
@adamjeffries
Merge pull request metaplex-foundation#402 from metaplex-foundation/f…
0927e3e 
…eature/ux-improvements

UI: ux improvements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blockiosaurus blockiosaurus blockiosaurus approved these changes

@thlorenz thlorenz Awaiting requested review from thlorenz

@roederw roederw Awaiting requested review from roederw

@lorisleiva lorisleiva Awaiting requested review from lorisleiva

@danenbm danenbm Awaiting requested review from danenbm

@austbot austbot Awaiting requested review from austbot

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@samuelvanderwaal @austbot @blockiosaurus