fix: Add Creator Minimum Balance Check #1051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KartikSoneji
requested review from
febo and
blockiosaurus
and removed request for
a team
KartikSoneji
force-pushed
the
fix/creator-minimum-balance-check
branch
2 times, most recently
from
dea7605 to
d159624
Compare
|
@KartikSoneji does this only apply to creators that are PDA addresses? |
|
This also applies to normal keypairs, since the creator can empty it out. |
KartikSoneji
force-pushed
the
fix/creator-minimum-balance-check
branch
from
d159624 to
49b4d23
Compare
samuelvanderwaal
previously approved these changes
Mar 27, 2023
KartikSoneji
force-pushed
the
fix/creator-minimum-balance-check
branch
from
49b4d23 to
64a0956
Compare
|
Thanks for this and the other PR! |
samuelvanderwaal
approved these changes
Mar 27, 2023
|
Happy to help :) |
I plan to deploy it this week. There are a couple of other issues raised I want to resolve first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If one of the creators of an NFT has less than the rent exempt amount in their wallet, and the royalty from the sale is not enough to bring the balance over the rent exempt minimum then the sale will fail.
A workaround is to skip paying creator royalties unless they result in a valid balance for the creator wallet.