Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: createAuctionV2 scheme #88

Merged
merged 3 commits into from
Dec 2, 2021
Merged

fix: createAuctionV2 scheme #88

merged 3 commits into from
Dec 2, 2021

Conversation

dkchv
Copy link
Contributor

@dkchv dkchv commented Dec 2, 2021

No description provided.

@kurpav kurpav self-requested a review December 2, 2021 14:26
@kurpav
Copy link
Contributor

kurpav commented Dec 2, 2021

@dkchv
What is the purpose of this PR?
The proposed schema is different from what is defined in the Rust smart contract

@dkchv
Copy link
Contributor Author

dkchv commented Dec 2, 2021 •
edited
Loading

@kurpav
Struct defined in program here: https://github.com/metaplex-foundation/metaplex/blob/master/rust/auction/program/src/processor/create_auction_v2.rs#L29

Current scheme serializes instantSale and name params only and avoid rest of params (end_auction_at, winners, etc).

Aslo, as you can see in snapshot the data is longer: https://github.com/metaplex/js/pull/88/files#diff-90401f87534bf4762dcc1f87b2e18b11fcf1cc6ac6ee77c072b75dc164e1d9c4R5

Fix PR fixes that difference.

@kurpav
Copy link
Contributor

kurpav commented Dec 2, 2021

@dkchv
ok, then I don't see instantSale and name params in the PR schema changes

@dkchv
Copy link
Contributor Author

dkchv commented Dec 2, 2021

@kurpav
My bad. Params added.

@kurpav kurpav merged commit ac808ad into metaplex-foundation:main Dec 2, 2021
@dkchv dkchv deleted the fix-create-auction-v2-scheme branch December 2, 2021 15:30
@zaxozhu
Copy link
Contributor

zaxozhu commented Dec 2, 2021

🎉 This PR is included in version 4.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kurpav kurpav kurpav approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dkchv @kurpav @zaxozhu