-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Allow Supply 0 on Master Editions #67
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austbot
suggested changes
Nov 21, 2021
this is a great fix ill bring it in but not the package json changes |
kespinola
force-pushed
the
fix/max-supply-0
branch
from
November 21, 2021 02:23
3802c4e
to
fb145e9
Compare
Thanks |
@kespinola ill fix tests, in a diff branch unless you want to here |
zaxozhu
changed the title
Allow Supply 0 on Master Editions
fix: Allow Supply 0 on Master Editions
Nov 22, 2021
kurpav
previously approved these changes
Nov 22, 2021
@kespinola there are a few updates that need to be made to fix types form
|
…T action from number to BN to support supply 0
Thanks for this. Closing in favor of #147. |
Sounds good. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The current implementation does not support setting supply to 0 because 0 is falsy in javascript.
Changes
Replace accepting a number as a parameter with
BN | null
. The caller is responsible for setting it.