Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: initial documentation #156

Merged
merged 12 commits into from
Jan 28, 2022
Merged

docs: initial documentation #156

merged 12 commits into from
Jan 28, 2022

Conversation

etodanik
Copy link
Collaborator

@etodanik etodanik commented Jan 22, 2022

Current Status:
This is still a draft. I'm planning to finish an initial pass documenting most of the actions by EOD Jan 22nd and then move on to adding inline code examples and more detailed usage documentation as a second pass after which I'll switch the PR to a ready for review mode.

Pull request to track typedoc documentation.

Some changes not related to docs for review:

  • I added a doc:watch command to be able to do yarn doc:watch and write docs easily
  • I am removing I prefixes from interfaces as I encounter them (ICancelBidParams becomes CancelBidParams) because we had a mixed bag and TypeScript mostly discourages prefixed interfaces
  • I am adding export to all the nested object parameter interfaces because typedoc doesn't include non-exported interfaces and types by default in the documentation. This is also good because end-users will be able to use those interfaces in their integrations of the JS SDK

src/actions/initStore.ts Outdated Show resolved Hide resolved
/**
* Initialize a {@link Store} account.
* This action will get a {@link Store} program derived account address for the provided wallet and initialize a store with that address, setting the given `wallet` as the admin
* @deprecated This action is deprecated, please use {@link initStoreV2} instead
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this deprecation correct? I don't see deprecation warnings in MPL or docs yet.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad. I kind of made an assumption here, but realized later on that V2 is still WIP. I'll remove the deprecation notice until V2 is production ready. Should I somehow state V2 to be not ready yet?

src/actions/placeBid.ts Outdated Show resolved Hide resolved
@aheckmann aheckmann marked this pull request as ready for review January 28, 2022 15:09
@aheckmann aheckmann merged commit a4274ec into main Jan 28, 2022
@aheckmann aheckmann deleted the docs/initial-documentation branch January 28, 2022 15:09
@kobyle69
Copy link

kobyle69 commented Mar 15, 2022

You have changed 'burnToken' params name and docs, specifically, 'token' to 'account'.

This leads to confusion since docs are pointing out to latest changed done in master branch - https://metaplex-foundation.github.io/js/interfaces/actions.BurnTokenParams.html

However, NPM packages goes only up to v4.12.0 which doesnt contain the changes above.

Sending param as doc states with 'account' will cause an exception.

Many hours lost on this, shouldn't there be a new NPM package with next tag so docs are in full correlation with latest available package via NPM?

@aheckmann

@etodanik
Copy link
Collaborator Author

etodanik commented Mar 15, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants