-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: initial documentation #156
Conversation
src/actions/initStore.ts
Outdated
/** | ||
* Initialize a {@link Store} account. | ||
* This action will get a {@link Store} program derived account address for the provided wallet and initialize a store with that address, setting the given `wallet` as the admin | ||
* @deprecated This action is deprecated, please use {@link initStoreV2} instead |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this deprecation correct? I don't see deprecation warnings in MPL or docs yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My bad. I kind of made an assumption here, but realized later on that V2 is still WIP. I'll remove the deprecation notice until V2 is production ready. Should I somehow state V2 to be not ready yet?
Co-authored-by: Aaron Heckmann <[email protected]>
You have changed 'burnToken' params name and docs, specifically, 'token' to 'account'. This leads to confusion since docs are pointing out to latest changed done in master branch - https://metaplex-foundation.github.io/js/interfaces/actions.BurnTokenParams.html However, NPM packages goes only up to v4.12.0 which doesnt contain the changes above. Sending param as doc states with 'account' will cause an exception. Many hours lost on this, shouldn't there be a new NPM package with next tag so docs are in full correlation with latest available package via NPM? |
Yes , this was in the plan but then this was frozen and I didn’t get
updates. It should 100% be updated everywhere.
Token is an absolutely incorrect name for it. It’s an account. Naming it
token can make it seem like you’re expecting a token mint, when in reality
you’re to provide the account where this token will be stored.
|
Current Status:
This is still a draft. I'm planning to finish an initial pass documenting most of the actions by EOD Jan 22nd and then move on to adding inline code examples and more detailed usage documentation as a second pass after which I'll switch the PR to a ready for review mode.
Pull request to track typedoc documentation.
Some changes not related to docs for review:
doc:watch
command to be able to doyarn doc:watch
and write docs easilyI
prefixes from interfaces as I encounter them (ICancelBidParams
becomesCancelBidParams
) because we had a mixed bag and TypeScript mostly discourages prefixed interfaces