Add configurable cl audits table #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linuskendall
referenced
this pull request
in rpcpool/digital-asset-rpc-infrastructure
Jul 26, 2023
|
Good call. I agree that this should be configurable since it's quite storage intensive. We'll merge our endpoint, too. It's experimental at the moment but if it's controlled via config I think it makes sense to include as an optional endpoint. |
linuskendall
force-pushed
the
cl_audits_upstream
branch
from
515ff53 to
642c98c
Compare
danenbm
requested review from
danenbm,
austbot and
NicolasPennie
and removed request for
austbot
danenbm
approved these changes
Oct 6, 2023
| @@ -75,6 +90,12 @@ where | |||
| txn.execute(query) | |||
| .await | |||
| .map_err(|db_err| IngesterError::StorageWriteError(db_err.to_string()))?; | |||
|
|
|||
|
|
|||
| // Insert the audit item after the insert into cl_items have been completed | |||
There was a problem hiding this comment.
Wouldn't you want insert to the audit table before inserting to cl_items, so that if the insert to cl_items fails, it remains in the audit table and is audited and fixed later?
NicolasPennie
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the cl_audits table which contains all the transactions for a specific compressed asset. This has some quite heavy increased data usage, so I have added a configuration param for this.
I think helius-labs have used this same table for a new rpc call they added so getting this merged in would help upstream those changes too later.