Change creator and collection verification to use upserts to support out of order #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erification occurs
* This allows out-of-order Bubblegum transactions to create and update the asset table. * Upsert leaf schema, owner, delegate, and seq separately since those are updated by all instructions and gated by sequence number to ensure freshest value. * Mint, burn, and decompress happen without regard to sequence number because they operate on unique fields. * Mint and burn have been updated but Decompress still needs to be fixed to handle out of order transactions. * Also remove unused 'filling' variable.
Also remove not null constraints for asset fields without defaults.
Also update redeem and decompress to not use leaf schema events.
compressed_seq won't work because decompression doesn't create a cl_event.
danenbm
force-pushed
the
danenbm/update-creators
branch
from
f678f24 to
2bc2946
Compare
nft_ingester/src/program_transformers/token_metadata/v1_asset.rs
Outdated
Show resolved
Hide resolved
danenbm
force-pushed
the
danenbm/update-creators
branch
from
e4af3a2 to
c91977a
Compare
danenbm
force-pushed
the
danenbm/update-creators
branch
from
7514ed6 to
c55f7a3
Compare
linuskendall
approved these changes
Jul 25, 2023
| .to_owned(), | ||
| ) | ||
| .build(DbBackend::Postgres); | ||
| txn.execute(query).await?; |
There was a problem hiding this comment.
does this query need a where check for example on SlotUpdated?
There was a problem hiding this comment.
if it cannot be reordered, then is the update needed atg all?
There was a problem hiding this comment.
It is still needed to be an update because if 'verify_creator` is processed first, then there will be a record but it won't actually have all this base information from the time of minting.
There was a problem hiding this comment.
does this query need a where check for example on SlotUpdated?
It does not need protection because the base creator info is ONLY filled in at time of mint.
There was a problem hiding this comment.
We will likely be updating this to support changes to creator array and collection.
…of order processing (#90) * Adding verified flag to asset_grouping table * Regenerate Sea ORM types * Remove null constraints on asset_grouping table * Regenerate Sea ORM types * Update digital asset types and ingester based on new Sea ORM objects * Setting new verified flag in asset_grouping table to be non null with default Also regenerating Sea ORM types * Separate out collection insert in mintV1 into separate upserts * Fix error message * Separate update collection base info from collection verified * Add group info seq to asset_grouping table * Regenerate Sea ORM types * Add group_info_seq checks to collection base info upsert * Add check for verified = true in grouping for Read API * Fix conditions for asset grouping updates * Require grouping to verified to be returned from API in all cases
danenbm
changed the title
muhitrhn
pushed a commit
to muhitrhn/digital-asset-rpc-infrastructure
that referenced
this pull request
Oct 6, 2023
muhitrhn
pushed a commit
to muhitrhn/digital-asset-rpc-infrastructure
that referenced
this pull request
Oct 6, 2023
…x-foundation#88) This reverts commit cfe2672.
muhitrhn
pushed a commit
to muhitrhn/digital-asset-rpc-infrastructure
that referenced
this pull request
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes
verifiedflag toasset_groupingto support out-of-order.Testing
getAssetreturns empty grouping. Then after the collection is verified,getAssetreturns the collection as a grouping. This is to remain consistent with existing API behavior.assettable #77 (comment) for more info on overall testing process.getAssetresultCreateTree/Mint,VerifyCreatorasset,asset_creators,cl_itemsmatch when instructions run forwards and backwards using PR code. PR code'scl_itemstable consistent with mainline code when instructions run forwards.assetandasset_creatorsincorrect on main when instructions run backwards.CreateTree/Mint,VerifyCollectionasset,asset_grouping,cl_itemsmatch when instructions run forwards and backwards using PR code. PR code'sassetandcl_itemstables consistent with mainline code when instructions run forwards.asset_groupingincorrect on main.CreateTree/Mint,VerifyCollection,UnverifyCollectionasset,asset_grouping,cl_itemsmatch when instructions run forwards and backwards using PR code.CreateTree/Mint,SetAndVerifyCollectionSetAndVerifyCollectiondoes not parse properly due to Blockbuster error. Not a regression.SetAndVerifyCollectiondoes not parse properly due to Blockbuster error. Not a regression.CreateTree/MintToCollection,UnverifyCollectionasset,asset_grouping,cl_itemsmatch when instructions run forwards and backwards using PR code.