Fix before/after cursors by decoding base58 keys. #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austbot
approved these changes
May 9, 2023
tahsintunan
referenced
this pull request
in helius-labs/digital-asset-rpc-infrastructure
Jun 22, 2023
* Add structured logging and reduce log noisiness (#48) * Fix GetAssetsByCreator query (#8) * Bump to 0.7.1 * Handle HTTP errors Handle and log http errors separately. * Make bgtask runner configurable Partially addresses metaplex-foundation#50. * Enable configurable retries Enable configurable retries for the bgtask. * Add purged task metric * add new task metric * Fixed nft ingester * Fix the reading of task timeout * Set slow statements to debug * Remove task name * Fix purge task * acc forwarder (#11) * acc forwarder * version to .0.1 * Fixing unused imports Cleaning out unused imports. * Hopefully final fix for interval handling * Fix interval * fix(das-api): fix getAssetProof * Fix before/after cursors. (#67) * Fix edition nonce (#78) * fix(ingester): fix compressed nft burn indexing (#24) (#80) * fix(ingester): fix compressed nft burn indexing * Small fix for asssetId calculation * feat(das-api): support searching assets by `jsonUri` parameter (#79) * add dto parameter * add dao condition * upd asset_data fetching to ensure single presence of asset_data in query * use asset.asset_data key for linking between asset/asset_data * fix: breaking arg order for array queries * chore: consistent arg order in `SearchAssets` destructuring * fix: breaking arg count for array params in searchAssets * fix: use IndexMap instead of BTreeMap --------- Co-authored-by: Nicolas Pennie <[email protected]> Co-authored-by: Linus Kendall <[email protected]> Co-authored-by: ethyi <[email protected]> Co-authored-by: Richard Wu <[email protected]> Co-authored-by: Austin Adams <[email protected]> Co-authored-by: Alex Tsymbal <[email protected]>
muhitrhn
pushed a commit
to muhitrhn/digital-asset-rpc-infrastructure
that referenced
this pull request
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before/after strings for pagination are validated as base58 strings.
However, when we decode them into Vec we use
as_bytes()which uses ascii values.Instead we need to bs58::decode them.