Configurable bgtask runner #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handle and log http errors separately.
Partially addresses metaplex-foundation#50.
Enable configurable retries for the bgtask.
linuskendall
commented
Apr 17, 2023
nft_ingester/src/tasks/mod.rs
Outdated
| pub async fn purge_old_tasks(conn: &DatabaseConnection) -> Result<DeleteResult, IngesterError> { | ||
| let cod = Expr::cust("NOW() - created_at::timestamp > interval '60 minute'"); //TOdo parametrize | ||
| pub async fn purge_old_tasks(conn: &DatabaseConnection, task_max_age: time::Duration) -> Result<DeleteResult, IngesterError> { | ||
| let cod = Expr::cust_with_values("NOW() - created_at::timestamp > interval '? seconds'", [task_max_age.as_secs()]); |
There was a problem hiding this comment.
This is broken, I think it doesn't actually do replacement.
austbot
approved these changes
May 10, 2023
muhitrhn
pushed a commit
to muhitrhn/digital-asset-rpc-infrastructure
that referenced
this pull request
Oct 6, 2023
…ion#56) * spelling fixes * fix: external_url returns correct url instead of null * Simplify specification version handling in get_content
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add configuration to the task runners, this helps address problems outlined in #50.
Adds support for a config file in addition to the environment variables. Environment variables overrides the config file values.