Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid unnecessary operations if Vec<Asset> is empty #229

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions digital_asset_types/src/dapi/common/asset.rs
Original file line number Diff line number Diff line change
Expand Up @@ -71,16 +71,27 @@ pub fn build_asset_response(
}
};

let (items, errors) = asset_list_to_rpc(assets, options);
AssetList {
let base_asset_list = AssetList {
AhzamAkhtar marked this conversation as resolved.
Show resolved Hide resolved
total,
limit: limit as u32,
page: page.map(|x| x as u32),
page : page.map(|x| x as u32),
Nagaprasadvr marked this conversation as resolved.
Show resolved Hide resolved
before,
after,
items: vec![],
errors: vec![],
cursor,
};

if assets.is_empty() {
return base_asset_list;
}

let (items, errors) = asset_list_to_rpc(assets, options);

AssetList {
items,
errors,
cursor,
..base_asset_list
}
}

Expand Down