Creators and collection batch mint verifications #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StanChe
approved these changes
Aug 12, 2024
blockbuster/blockbuster/Cargo.toml
Outdated
Comment on lines
14
to
15
| spl-account-compression = { git = "https://github.com/StanChe/solana-program-library.git", branch = "feature/init_with_root", features = ["no-entrypoint"] } | ||
| spl-noop = { git = "https://github.com/StanChe/solana-program-library.git", branch = "feature/init_with_root", features = ["no-entrypoint"] } |
There was a problem hiding this comment.
you could also use workspace import here
Co-authored-by: Stanislav Cherviakov <[email protected]>
RequescoS
reviewed
Aug 13, 2024
| ) -> Self { | ||
| Self { | ||
| rightmost_root: args.rightmost_root, |
RequescoS
reviewed
Aug 13, 2024
| @@ -545,9 +555,39 @@ impl<T: ConnectionTrait + TransactionTrait, D: BatchMintDownloader> BatchMintPer | |||
| } | |||
| } | |||
|
|
|||
| pub async fn validate_batch_mint(batch_mint: &BatchMint) -> Result<(), BatchMintValidationError> { | |||
| pub async fn validate_batch_mint( | |||
There was a problem hiding this comment.
yep, we have separate ticket for these changes
RequescoS
reviewed
Aug 13, 2024
| @@ -11,7 +11,7 @@ use spl_concurrent_merkle_tree::concurrent_merkle_tree::ConcurrentMerkleTree; | |||
| use std::collections::HashMap; | |||
| use std::str::FromStr; | |||
|
|
|||
| pub fn generate_batch_mint(size: usize) -> BatchMint { | |||
| pub fn generate_batch_mint(size: usize, creators_verified: bool) -> BatchMint { | |||
There was a problem hiding this comment.
this fn also can be imported from sdk
RequescoS
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR adds creator and collection verifications to the batch mint operation.
Why
Some of the assets in batch minting may have verified creators and collections.
Typically, creators should verify themselves by sending a transaction, which involves signature verification. In the batch minting implementation, a similar functionality is included. Here, creators must sign a hash and include this hash in the batch mint JSON file. On the indexer side, we verify the validity of the signature. If everything is correct, the creator is verified.
For collection verification, a special instruction
finalize_tree_with_root_and_collectionmust be sent. The success of this transaction proves that the collection is verified by its creator. On the indexer side, we need to check if the collection in the batch mint object matches the one in the instruction.How
Several new checks have been added to the batch mint persister to verify creators and collections. Additionally, parsing of the
finalize_tree_with_root_and_collectionBubblegum instruction has been implemented. The new functionality is also covered with tests.