-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to use Token Metadata (and latest Bubblegum) Rust clients #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danenbm
requested review from
linuskendall,
NicolasPennie,
fanatid,
niks3089,
Juanito87 and
blockiosaurus
February 1, 2024 05:30
niks3089
approved these changes
Feb 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tested and works great
niks3089
added a commit
to helius-labs/digital-asset-rpc-infrastructure
that referenced
this pull request
Feb 19, 2024
* Fix cNFT update metadata indexing (metaplex-foundation#167) * Update to use Token Metadata (and latest Bubblegum) Rust clients (metaplex-foundation#168) * Use Token Metadata and latest Bubblegum Rust clients, new blockbuster * Remove candy machine and candy guard * Update lock file * Improve Master Edition V1 and V2 indexing * Update to use blockbuster published crate * Update lock file * Update Token Metadata and Blockbuster deps (metaplex-foundation#170) * Update to latest token metadata and blockbuster crates * Update Cargo lock file * Add DAS integration tests (metaplex-foundation#169) * Add das integration tests * Delete unused snapshots * Delete unnecessary test data * Clean up dependencies * Nit * Address comments * Add README.md * Fix warnings * feat(ops): add ops crate for bundling misc tools. add a tree backfiller based on cl_audits_v2. * Fix NFT race condition (metaplex-foundation#172) * Add das integration tests * Delete unused snapshots * Delete unnecessary test data * Clean up dependencies * Nit * Address comments * Add README.md * Fix warnings * Fix asset race condition * Add missing files * Fix warnings * Fix missing slot updated * Address comments * Nit * Update Rust version and missing dirs in docker build (metaplex-foundation#173) --------- Co-authored-by: Nicolas Pennie <[email protected]> Co-authored-by: Michael Danenberg <[email protected]> Co-authored-by: pmantica11 <[email protected]> Co-authored-by: Kyle Espinola <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update 2/2/2024
asset
,asset_creators
,asset_grouping
,asset_data
, andasset_v1_account_attachments
tables and looks like expected data from load generation.asset
,asset_creators
,asset_grouping
,asset_data
, andcl_items
tables).Notes
MasterEditionV1
andMasterEditionV2
indexing.attachment_type
column was hardcoded tomaster_edition_v1
, which is now fixed to use the function argument.print_current_supply
andprint_max_supply
are currently hardcoded inasset_to_rpc
anyways, and even if data was being used, the same info is being stored no matter what the key is.Testing
asset_data
indexing. But I was also able to see a load generated NFT indexed inasset
,asset_creators
, andasset_grouping
tables.Mainline asset data from load generator.
This PR asset data from load generator
Mainline
MasterEditionV2
data indexed before this changeMasterEditionV2
data indexed after this PR