workspace: add program_transformers #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fanatid
force-pushed
the
pt-move-program-transformers
branch
2 times, most recently
from
75e4825 to
52d1773
Compare
fanatid
force-pushed
the
pt-move-program-transformers
branch
from
52d1773 to
5bd27d5
Compare
|
Updated! |
danenbm
reviewed
Feb 15, 2024
Comment on lines
-68
to
+78
| tree: Set(tree_id.to_vec()), | ||
| level: Set(i), | ||
| node_idx: Set(node_idx), | ||
| hash: Set(p.node.as_ref().to_vec()), | ||
| seq: Set(change_log_event.seq as i64), | ||
| leaf_idx: Set(leaf_idx), | ||
| tree: ActiveValue::Set(tree_id.to_vec()), | ||
| level: ActiveValue::Set(i), | ||
| node_idx: ActiveValue::Set(node_idx), | ||
| hash: ActiveValue::Set(p.node.as_ref().to_vec()), | ||
| seq: ActiveValue::Set(change_log_event.seq as i64), | ||
| leaf_idx: ActiveValue::Set(leaf_idx), |
There was a problem hiding this comment.
Just curious what's the style choice reasoning for adding the more full path with ActiveValue here? I don't dislike it but it seems like extra typing given that it was already there without it.
There was a problem hiding this comment.
I'm not familiar with sea-orm and for me, glob import with NoSet / Set looked like magic. Also, just checked https://docs.rs/sea-orm/0.12.14/sea_orm/entity/enum.ActiveValue.html in the docs right now -- this is an enum, we do not usually use enum variants without enum name?
Happy to return NoSet / Set back if that works for you better
danenbm
reviewed
Feb 15, 2024
danenbm
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #141
Move
program_transformersto separate crate