Update to Solana 1.16 and use new Bubblegum Rust client #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update to Solana 1.16.16 (version that does not have tokio pinned and solana-transaction-status supports Borsh 0.10.3). * Update blockbuster to latest branch that supports Bubblegum Update Metadata instruction parsing (still a commit ID). * Update to Borsh 0.10.3. * Update to Plerkle Messenger 1.6.0. * Update to Bubblegum 1.0.1-beta.2 (Rust client version that supports Update Metadata and limits to Borsh < 1.0.0). * Update to SPL Account Compression 0.2.0. * Update to Anchor 0.28.0. * Update Candy Machine and Candy Guard to 2.0.x. * spl-associated-token-account and spl-token use same version ranges as Bubblegum program crate. * Update SPL No-op. * MPL Token Metadata exact version: 2.0.0-beta.1.
danenbm
changed the title
danenbm
requested review from
linuskendall,
NicolasPennie,
febo and
blockiosaurus
fanatid
reviewed
Oct 12, 2023
danenbm
force-pushed
the
danenbm/update-metadata
branch
from
b8214bf to
fbaae25
Compare
danenbm
commented
Oct 13, 2023
| @@ -71,17 +71,15 @@ impl IngesterConfig { | |||
| } | |||
|
|
|||
| pub fn get_account_backfill_stream_worker_count(&self) -> u32 { | |||
| self.account_backfill_stream_worker_count | |||
| .unwrap_or_else(|| self.get_account_stream_worker_count()) | |||
| self.account_backfill_stream_worker_count.unwrap_or(0) | |||
There was a problem hiding this comment.
Have to set this to zero for now because we are not configuring any backfill streams in the plugin. @fanatid will touch base next week since we previously talked about the config, and we can see what is good solution.
| } | ||
|
|
||
| pub fn get_transaction_stream_worker_count(&self) -> u32 { | ||
| self.transaction_stream_worker_count.unwrap_or(2) | ||
| } | ||
|
|
||
| pub fn get_transaction_backfill_stream_worker_count(&self) -> u32 { | ||
| self.transaction_backfill_stream_worker_count | ||
| .unwrap_or_else(|| self.get_transaction_stream_worker_count()) | ||
| self.transaction_backfill_stream_worker_count.unwrap_or(0) |
There was a problem hiding this comment.
Have to set this to zero for now because we are not configuring any backfill streams in the plugin. @fanatid will touch base next week since we previously talked about the config, and we can see what is good solution.
NicolasPennie
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Updates DAS API to use Solana 1.16 versions, plus the initial changes for Bubblegum Update Metadata (uses the Bubblegum Rust client that supports Update Metadata, but doesn't actually do anything with it yet).
Details