MTG-886 Change config for TCP and Redis messengers #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We definitely have a conflicting changes in #310 |
|
Close this PR because it doesn't make any sense anymore. Before that there were two receivers: Redis and TCP. But now Aura ingester supports only Redis. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR changes config for TCP and Redis messengers a little bit. Before these changes there were 3 different config variables for messenger, now only one.
In .env.example there is comment which describes how to write the config now.
Also main func was slightly changed. Now launching workers for accounts and transactions updates listening is more structured and defined in one place.