Introduce Account, HotWallet, Create AccountMeta #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mike-metaplex
approved these changes
Sep 20, 2022
|
This will be treated as a new release correct? Since it's breaking changes will it be updated to 2.0.0? |
|
@mike-metaplex yes 2.0. I am started mapping 2.0 for this lib |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PRs Extract the Account to an interface. The idea is that other types of wallets can be implemented.
The problem is that the current Account also contains Meta. This will create a breaking change on every transaction using Account.Meta. This was a bad implementation from the beginning. The Signing Method will be extracted to the account and live outside the transaction.
Hot wallet implementation is also added to maintain functionality.