Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for serializing partially signed transactions #179

Merged
merged 12 commits into from
Jun 22, 2022
Merged

Added support for serializing partially signed transactions #179

merged 12 commits into from
Jun 22, 2022

Conversation

samdowd
Copy link
Contributor

@samdowd samdowd commented Jun 20, 2022

Closes #178

  • Made serialization process reserve space for null signatures instead of trimming them
  • Fixed public Transaction.Signature model to actually be public

@ajamaica
Copy link
Contributor

Can you rebase master?

@samdowd
Copy link
Contributor Author

samdowd commented Jun 22, 2022

Done!

@ajamaica
Copy link
Contributor

Please rebase next time if possible XD. I made my life easier reviewing.

@ajamaica ajamaica merged commit f487b25 into metaplex-foundation:master Jun 22, 2022
@samdowd samdowd deleted the partial-sign-serialization branch June 22, 2022 18:16
@samdowd
Copy link
Contributor Author

samdowd commented Jun 22, 2022

Yep, my bad! Thanks for merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Partially signed transactions get their signatures trimmed during serialization
3 participants
@samdowd @ajamaica @dhruv500