-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(treespec): add tree broadcast functions broadcast_common
, tree_broadcast_common
, tree_broadcast_map
, and tree_broadcast_map_with_path
#87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XuehaiPan
added
enhancement
New feature or request
cxx
Something related to the CXX source code
py
Something related to the Python source code
labels
Oct 1, 2023
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #87 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 4 4
Lines 428 468 +40
=========================================
+ Hits 428 468 +40
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
XuehaiPan
force-pushed
the
broadcast
branch
17 times, most recently
from
October 1, 2023 19:19
9483b94
to
b297016
Compare
8 tasks
XuehaiPan
force-pushed
the
broadcast
branch
6 times, most recently
from
October 6, 2023 17:57
438ef1b
to
4180be3
Compare
XuehaiPan
force-pushed
the
broadcast
branch
6 times, most recently
from
October 7, 2023 17:42
23a82f1
to
762cca3
Compare
JieRen98
approved these changes
Oct 11, 2023
XuehaiPan
changed the title
feat(treespec): add tree broadcast methods
feat(treespec): add tree broadcast functions Oct 12, 2023
broadcast_common
, tree_broadcast_common
, tree_broadcast_map
, and tree_broadcast_map_with_path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cxx
Something related to the CXX source code
enhancement
New feature or request
py
Something related to the Python source code
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe your changes in detail.
Add new methods and functions:
PyTreeSpec.broadcast_to_common_suffix()
tree_broadcast_common()
broadcast_common()
tree_broadcast_map()
tree_broadcast_map_with_path()
Motivation and Context
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
You can use the syntax
close #15213
if this solves the issue #15213Types of changes
What types of changes does your code introduce? Put an
x
in all the boxes that apply:Checklist
Go over all the following points, and put an
x
in all the boxes that apply.If you are unsure about any of these, don't hesitate to ask. We are here to help!
make format
. (required)make lint
. (required)make test
pass. (required)