Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: split implementation files and add more inline / constexpr / noexcept qualifiers #159

Merged
merged 8 commits into from
Oct 3, 2024

Conversation

XuehaiPan
Copy link
Member

Description

Describe your changes in detail.

Motivation and Context

Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
You can use the syntax close #15213 if this solves the issue #15213

  • I have raised an issue to propose this change (required for new features and bug fixes)

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide. (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly. (required for a bug fix or a new feature)
  • I have updated the documentation accordingly.
  • I have reformatted the code using make format. (required)
  • I have checked the code using make lint. (required)
  • I have ensured make test pass. (required)

@XuehaiPan XuehaiPan added enhancement New feature or request cxx Something related to the CXX source code labels Sep 30, 2024
@XuehaiPan XuehaiPan force-pushed the split-files branch 2 times, most recently from 3cee5d5 to 219ca02 Compare September 30, 2024 17:28
Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (3d78747) to head (fc96a61).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #159   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           12        12           
  Lines         1267      1267           
=========================================
  Hits          1267      1267           
Flag Coverage Δ
unittests 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@XuehaiPan XuehaiPan force-pushed the split-files branch 18 times, most recently from 2361e5f to 8718be2 Compare October 2, 2024 08:26
@XuehaiPan XuehaiPan changed the title refactor: split implementation files and make more functions inlined refactor: split implementation files and add more inline / constexpr / noexcept qualifiers Oct 2, 2024
@XuehaiPan XuehaiPan force-pushed the split-files branch 2 times, most recently from 1db6ccf to 382ac4a Compare October 2, 2024 13:13
@XuehaiPan XuehaiPan force-pushed the split-files branch 4 times, most recently from 82113de to c68f341 Compare October 2, 2024 18:04
@XuehaiPan XuehaiPan merged commit bf7f5b2 into metaopt:main Oct 3, 2024
120 checks passed
@XuehaiPan XuehaiPan deleted the split-files branch October 3, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cxx Something related to the CXX source code enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant