-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: split implementation files and add more inline
/ constexpr
/ noexcept
qualifiers
#159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XuehaiPan
added
enhancement
New feature or request
cxx
Something related to the CXX source code
labels
Sep 30, 2024
XuehaiPan
force-pushed
the
split-files
branch
2 times, most recently
from
September 30, 2024 17:28
3cee5d5
to
219ca02
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #159 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 12 12
Lines 1267 1267
=========================================
Hits 1267 1267
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
XuehaiPan
force-pushed
the
split-files
branch
18 times, most recently
from
October 2, 2024 08:26
2361e5f
to
8718be2
Compare
XuehaiPan
changed the title
refactor: split implementation files and make more functions inlined
refactor: split implementation files and add more Oct 2, 2024
inline
/ constexpr
/ noexcept
qualifiers
XuehaiPan
force-pushed
the
split-files
branch
2 times, most recently
from
October 2, 2024 13:13
1db6ccf
to
382ac4a
Compare
XuehaiPan
force-pushed
the
split-files
branch
4 times, most recently
from
October 2, 2024 18:04
82113de
to
c68f341
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe your changes in detail.
Motivation and Context
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
You can use the syntax
close #15213
if this solves the issue #15213Checklist
Go over all the following points, and put an
x
in all the boxes that apply.If you are unsure about any of these, don't hesitate to ask. We are here to help!
make format
. (required)make lint
. (required)make test
pass. (required)