Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(typing): expose Python implementation for C utilities for namedtuple and PyStructSequence #157

Merged
merged 3 commits into from
Sep 12, 2024

Conversation

XuehaiPan
Copy link
Member

Description

Describe your changes in detail.

Add a wrapped version that has attributes __cxx_implementation__ and __python_implementation__ can be accessible.

Motivation and Context

Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
You can use the syntax close #15213 if this solves the issue #15213

  • I have raised an issue to propose this change (required for new features and bug fixes)

Expose Python implementation for PyTorch Dynamo support.

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide. (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly. (required for a bug fix or a new feature)
  • I have updated the documentation accordingly.
  • I have reformatted the code using make format. (required)
  • I have checked the code using make lint. (required)
  • I have ensured make test pass. (required)

@XuehaiPan XuehaiPan added enhancement New feature or request py Something related to the Python source code integration Integration for other packages labels Sep 11, 2024
@XuehaiPan XuehaiPan self-assigned this Sep 11, 2024
Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (0d2f38d) to head (f9e3c85).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##              main      #157    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           11        12     +1     
  Lines         1150      1274   +124     
==========================================
+ Hits          1150      1274   +124     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@XuehaiPan XuehaiPan force-pushed the python-implementation branch 6 times, most recently from 5855202 to 84bfd03 Compare September 12, 2024 12:05
@XuehaiPan XuehaiPan merged commit a7042df into metaopt:main Sep 12, 2024
53 checks passed
@XuehaiPan XuehaiPan deleted the python-implementation branch September 12, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request integration Integration for other packages py Something related to the Python source code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant