Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add proper .gitignore #66

Merged
merged 1 commit into from
Apr 28, 2021
Merged

Add proper .gitignore #66

merged 1 commit into from
Apr 28, 2021

Conversation

skalee
Copy link
Contributor

@skalee skalee commented Apr 28, 2021

I guess this is non-controversial.

@skalee skalee requested a review from opoudjis April 28, 2021 00:47
ronaldtse
ronaldtse requested changes Apr 28, 2021
View reviewed changes
Copy link
Contributor

@ronaldtse ronaldtse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add .DS_Store? Thanks.

@skalee skalee requested a review from ronaldtse April 28, 2021 03:27
@ronaldtse ronaldtse merged commit 2278867 into master Apr 28, 2021
@ronaldtse
Copy link
Contributor

Thanks @skalee !

@ronaldtse ronaldtse deleted the gitignore branch April 28, 2021 04:22
@ronaldtse ronaldtse mentioned this pull request May 29, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@opoudjis opoudjis Awaiting requested review from opoudjis

@ronaldtse ronaldtse Awaiting requested review from ronaldtse

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skalee @ronaldtse